Zelgadis
Following precautions taken to ensure accurate bug report:
Tested with a clean installation of SmartFTP 1.0 #981 as well as the currently available developer build (as of 29.05.2004) in sequence
Tested with three different remote FTPd (gnFTPd, RaidenFTPd and pureFTPd)
Test subject:
Throughout the bug report, the file used to do any tests is named "test{file.exe" which is a unmodified, renamed SFTPMSI.exe and is therefore 3.225.472 Bytes in size
A directory named "test{directory"
Test run:
The follwing actions are executed in the provided FTP log:
File upload: File "test{file.exe" is being uploaded
File rename: File "test{file.exe" is being renamed to "test}file.exe"
File delete: File "test}file.exe" is being deleted
Directory create: Directory "test{directory" is being created
Directory rename: Directory "test{directory" is being renamed to test}directory"
Directory delete: Directory "test}directory" is being deleted
You can get the log file here: Link
You can get the screenshot here: Link
The log file was saved with SmartFTP. Really worth of mentioning is the fact, that the log file is totally uncorrupted.
None of the memory dumps showed in the output window will actually be saved into the log.
This exposes the location the flaw is occuring in program code very much, as you can infer that the log display control is defective rather than the log buffer.
Behaviour:
An unpaired "{" or "}" group bracket appearing in the FTP log window will cause some of the memory to be dumped into it.
Since neither the actual action nor the saved log is affected by that, I would assume that the control itself is defective, as already mentioned before.
However, I don't know whether this is a richedit control or something custom-made, so this is all up to the programmer.
Please also notice that I have Windows XP SP2 RC1 installed, however this behaviour also occurs in SP1 as a friend of mine can confirm that.
System information copied from SmartFTP:
That's it. Only a very minor issue, but somewhat odd, since I'm pretty much sure, that I'm not the first person to use unpaired group brackets in a filename (even if it was just by accident).
So please keep up the excellent work, I appreciate your work very much since you are distributing all this for free personal usage, and on top of that, SmartFTP is probably the best FTP client available.
Have a nice day!
- Zelgadis
Tested with a clean installation of SmartFTP 1.0 #981 as well as the currently available developer build (as of 29.05.2004) in sequence Tested with three different remote FTPd (gnFTPd, RaidenFTPd and pureFTPd)Test subject:
Throughout the bug report, the file used to do any tests is named "test{file.exe" which is a unmodified, renamed SFTPMSI.exe and is therefore 3.225.472 Bytes in size A directory named "test{directory"Test run:
The follwing actions are executed in the provided FTP log:
File upload: File "test{file.exe" is being uploaded File rename: File "test{file.exe" is being renamed to "test}file.exe" File delete: File "test}file.exe" is being deleted Directory create: Directory "test{directory" is being created Directory rename: Directory "test{directory" is being renamed to test}directory" Directory delete: Directory "test}directory" is being deletedYou can get the log file here: Link
You can get the screenshot here: Link
The log file was saved with SmartFTP. Really worth of mentioning is the fact, that the log file is totally uncorrupted.
None of the memory dumps showed in the output window will actually be saved into the log.
This exposes the location the flaw is occuring in program code very much, as you can infer that the log display control is defective rather than the log buffer.
Behaviour:
An unpaired "{" or "}" group bracket appearing in the FTP log window will cause some of the memory to be dumped into it.
Since neither the actual action nor the saved log is affected by that, I would assume that the control itself is defective, as already mentioned before.
However, I don't know whether this is a richedit control or something custom-made, so this is all up to the programmer.
Please also notice that I have Windows XP SP2 RC1 installed, however this behaviour also occurs in SP1 as a friend of mine can confirm that.
System information copied from SmartFTP:
+- System -----------------------------
Microsoft Windows XP Professional
Service Pack 2, v.2096 (Build 2600)
CPU Speed : 3104 MHz
Total Memory : 1048028 KB
Free Memory : 805496 KB
+- SmartFTP ---------------------------
Version : 1.0.982.3
Time Stamp : 2004-05-02 16:30:08
+- Application DLL --------------------
controls.dll : 1.6.982.3
ftpapi.dll : 2.0.982.3
language.dll : 1.0.982.3
reseng.dll : 1.3.982.3
+- System DLL -------------------------
shell32.dll : 6.00.2900.2096 (xpsp_sp2_rc1.040311-2315)
shlwapi.dll : 6.00.2900.2096 (xpsp_sp2_rc1.040311-2315)
comctl32.dll : 6.0 (xpsp_sp2_rc1.040311-2315)
riched20.dll : 5.30.23.1217
schannel.dll : 5.1.2600.2096 (xpsp_sp2_rc1.040311-2315)
+- Internet Explorer ------------------
Version : 6.0.2900.2096
+- Winsock ----------------------------
Winsock : 2.2
That's it. Only a very minor issue, but somewhat odd, since I'm pretty much sure, that I'm not the first person to use unpaired group brackets in a filename (even if it was just by accident).
So please keep up the excellent work, I appreciate your work very much since you are distributing all this for free personal usage, and on top of that, SmartFTP is probably the best FTP client available.
Have a nice day!
- Zelgadis