Jump to content


Photo

Beta: "" (null) dir name crashes SmartFTP Client


This topic has been archived. This means that you cannot reply to this topic.
3 replies to this topic

#1 Schnena

Schnena
  • Members
  • 7 posts

Posted 22 February 2008 - 09:19 AM

If a FTPd lists a directory w/ a blank dirname ("") the client fully crashes and needs to be restarted.

This occurs in the current 3.0 beta.

Edited by Schnena, 22 February 2008 - 09:23 AM.


#2 mb

mb

    Developer

  • Administrators
  • 11521 posts

Posted 22 February 2008 - 10:13 AM

Hello ..

Thank you for reporting this issue. Can you post the raw directory listing of the folder containg the empty folder/file? Right click on the folder then select "Raw Directory Listing" from the context menu.
I have never seen a listing with an empty name. I also doubt that no name is a valid name.

Regards,
Mat

#3 mb

mb

    Developer

  • Administrators
  • 11521 posts

Posted 22 February 2008 - 11:48 AM

The crash won't happen in the next version. However an empty folder name is not valid and therefore will result in unexpected behavior (but not more crashes).

#4 Schnena

Schnena
  • Members
  • 7 posts

Posted 22 February 2008 - 11:50 AM

Hello ..

Thank you for reporting this issue. Can you post the raw directory listing of the folder containg the empty folder/file? Right click on the folder then select "Raw Directory Listing" from the context menu.
I have never seen a listing with an empty name. I also doubt that no name is a valid name.

Regards,
Mat


It definitely is not a valid name at all. As you're probably aware from my other post today, I use a custom FTP daemon that I developed myself (for dealing w/ encrypted files). It had a bug and was outputting a null directory name, which didn't crash other FTP clients so I never noticed, but does crash SmartFTP. I have fixed the bug in my daemon, so it is no longer an issue for me, but just thought I would point out the bug so you could code some protection into SmartFTP (if desired) just in case anyone else ever had this issue (the fewer possible causes of crashes the better, right?).

The dirlist was completely normal except lacked any text at all for the directory name. Should be fairly easy to replicate if you want to fix it, although as you mentioned, as its not a valid dir name I doubt this is a common issue.

Edited by Schnena, 22 February 2008 - 11:51 AM.